Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DO NOT SQUASH MERGE] Batch merge PRs #16554

Merged
merged 2 commits into from
Oct 20, 2019
Merged

[DO NOT SQUASH MERGE] Batch merge PRs #16554

merged 2 commits into from
Oct 20, 2019

Conversation

reminisce
Copy link
Contributor

@reminisce reminisce commented Oct 20, 2019 •
edited
Loading

Description

Batch merge PRs that have been reviewed and approved for 1.6 release.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Alicia1529 and others added 2 commits October 19, 2019 21:51
@Alicia1529 @reminisce
numpy op doc: max, min, prod (#16506)
79c08d3
@kshitij12345 @reminisce
add interface for rand
c2cf2a3 
add relevant tests

address comments.

* fix document string -> Returns description.

Fix
@reminisce reminisce requested a review from szha as a code owner October 20, 2019 05:57
@reminisce reminisce merged commit b949716 into master Oct 20, 2019
@reminisce reminisce mentioned this pull request Oct 20, 2019
Closed
6 tasks
@szha szha deleted the numpy_1_6_prs branch August 13, 2020 04:16
@szha szha restored the numpy_1_6_prs branch August 13, 2020 04:16
@szha szha deleted the numpy_1_6_prs branch August 13, 2020 04:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reminisce @Alicia1529 @kshitij12345